streamich/react-use

useEnsuredForwardedRef not working with callback refs

Open

#805 opened on Nov 26, 2019

View on GitHub
 (2 comments) (1 reaction) (0 assignees)TypeScript (43,979 stars) (3,273 forks)batch import
bughelp wanted

Description

If the forwarded ref is a callback ref the callback isn't called properly.

useEnsuredForwardedRef should check if the passed ref is a callback-function and if that's the case call it to set the ref.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding React refsFamiliarity with useRef and forwardRef
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the implementation of useEnsuredForwardedRef in the repository. The hook currently may not handle callback refs. To fix, add a check: if the forwarded ref is a function (callback ref), call it with the value instead of assigning to .current. Write unit tests to verify both object refs and callback refs work correctly.