streamich/react-use

useEnsuredForwardedRef not working with callback refs

Open

#805 opened on Nov 26, 2019

View on GitHub
 (2 comments) (1 reaction) (0 assignees)TypeScript (3,273 forks)batch import
bughelp wanted

Repository metrics

Stars
 (43,979 stars)
PR merge metrics
 (Avg merge 1743d 9h) (1 merged PR in 30d)

Description

If the forwarded ref is a callback ref the callback isn't called properly.

useEnsuredForwardedRef should check if the passed ref is a callback-function and if that's the case call it to set the ref.

Contributor guide

Research direction
Examine the implementation of useEnsuredForwardedRef in the react use library. Understand how forwardedRef is currently used and modify it to handle callback refs by checking if it is a function and calling it with the current value.
Tech stack
reacttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75