streamich/react-use

Remove warnings from `useDeepCompareEffect`

Open

#755 opened on Nov 6, 2019

View on GitHub
 (8 comments) (0 reactions) (0 assignees)TypeScript (3,273 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (43,979 stars)
PR merge metrics
 (Avg merge 1743d 9h) (1 merged PR in 30d)

Description

Is your feature request related to a problem? Please describe.

useDeepCompareEffect gives warnings when using it with primitive dependencies. This is frustrating for the common case where dependencies could either undefined or an object that you'd like to be deep-compared.

Describe the solution you'd like

Remove warnings from useDeepCompareEffect or provide a way to suppress warnings.

Contributor guide

Research direction
Examine the implementation of useDeepCompareEffect and the warning logic; propose a way to suppress or remove warnings for primitive dependencies.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React hooks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70