streamich/react-use

Remove warnings from `useDeepCompareEffect`

Open

#755 opened on Nov 6, 2019

View on GitHub
 (8 comments) (0 reactions) (0 assignees)TypeScript (43,979 stars) (3,273 forks)batch import
buggood first issuehelp wanted

Description

Is your feature request related to a problem? Please describe.

useDeepCompareEffect gives warnings when using it with primitive dependencies. This is frustrating for the common case where dependencies could either undefined or an object that you'd like to be deep-compared.

Describe the solution you'd like

Remove warnings from useDeepCompareEffect or provide a way to suppress warnings.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript basicsReact hooks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Find the implementation of useDeepCompareEffect in the source code (likely in src/useDeepCompareEffect.ts). Examine the warning logic and decide whether to remove it or add a suppression option. Read the issue comments for guidance. Ensure any changes don't break existing tests.