streamich/react-embed

Could you add className passthrough?

Open

#693 opened on Oct 13, 2021

View on GitHub
 (3 comments) (2 reactions) (1 assignee)TypeScript (19 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (253 stars)
PR merge metrics
 (PR metrics pending)

Description

It would be great to have a className passthrough prop. In the example below we're trying to put an aspect ratio class directly on the Embed element. It doesn't work if you put it on the parent.

<Embed
  className="aspect-w-16 aspect-h-9"
  url={embedUrl}
/>

That would be super helpful, thanks.

Contributor guide

Research direction
Implement className prop passthrough by spreading the prop onto the root element of the Embed component.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90