streamich/react-embed

DailyMotion will not show if url contains queryString

Open

#566 opened on Apr 26, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (19 forks)github user discovery
buggood first issuehelp wanted

Repository metrics

Stars
 (253 stars)
PR merge metrics
 (PR metrics pending)

Description

with queryString: https://www.dailymotion.com/video/x80vg7f?playlist=x5nmbq without queryString: https://www.dailymotion.com/video/x80vg7f

react-embed seems to return void if contains queryString no matter it is meaningless or not

Contributor guide

Research direction
Inspect the DailyMotion embed component's URL parsing logic; determine why query strings cause the component to return void.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80