storybookjs/storybook

[Bug]: Line highlighting in onboarding is slightly misaligned

Open

#27164 opened on May 15, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
addon: onboardingbughelp wantedsev:S4ui

Description

Describe the bug

This problem is best described with a video:

https://github.com/storybookjs/storybook/assets/5678122/77201dc1-bbe4-4393-b4a0-df25bfee85fa

Some important screenshots from that video:

image

image

To Reproduce

See stories at https://next--635781f3500dd2c49e189caf.chromatic.com/?path=/story/addons-onboarding-features-writestoriesmodal--default

Or try it out in a fresh React sandbox:

  1. https://stackblitz.com/~/edit/github-duyqxc?file=.storybook%2Fmain.js&initialPath=%2F%3Fonboarding%3Dtrue
  2. Change the URL of the preview to the right and add /?onboarding=true

System

Storybook 8.1

Additional context

No response

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic understanding of Storybook's onboarding addon
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the line highlighting in the onboarding WriteStoriesModal component. Review the CSS styling for the highlighted lines to find the alignment issue. Check the featured stories URL provided for reproduction.