storybookjs/storybook

[Bug]: HMR issues on renaming stories

Open

#25788 opened on Jan 29, 2024

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
bughelp wantedsev:S3

Description

Describe the bug

originally filed here

Project: MealDrop Version: 8.0.0-alpha.14 Bug/feedback:

When renaming the story file of which you are visiting, a lot of weird things happen, it's best described in a video:

https://github.com/storybookjs/storybook/assets/1671563/540e03b8-82bf-4893-a0e3-adfe8058cf3f

The issues which happen are: 1 - The story of which you renamed somehow changes order and goes to the bottom of the list (there is no storySort being used) 2 - An importers[path] is not a function error is flashed in the screen:

3 - The UI goes into a funky state where there's some sort of negative margin and the toolbar is unreachable (until you close the addon panel, which is not really closed)

To Reproduce

  1. Go to https://github.com/yannbf/mealdrop/tree/storybook/8.0.0
  2. Visit a story
  3. Rename its story file to something else (e.g. add an A at the end)

System

No response

Additional context

No response

Contributor guide

Tech stack
typescriptreact
Domain
frontenddeveloper experienceperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
TypeScriptReactStorybook basicsHMR concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the HMR flow in Storybook when renaming story files. Focus on how importers are mapped and why the order changes. Look at the core package (e.g., core/src) and the builder (vite or webpack) for HMR update logic. The error `importers[path] is not a function` suggests a mismatch in the importer map. Review the linked discussion at https://github.com/storybookjs/storybook/discussions/25687#discussioncomment 8245240 for additional context.