storybookjs/storybook

[Bug]: when using manager.ts sidebar filters, controls don't show up

Open

#25714 opened on Jan 23, 2024

View on GitHub
 (2 comments) (2 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
addon: controlsbughelp wantedsev:S3tags

Description

Describe the bug

We use storybook for screenshot tests, and so we have a few extra stories for screenshots only that we like to hide from the sidebar. We do this using manager.ts with the following config:

import { addons } from '@storybook/manager-api'

addons.setConfig({
  sidebar: {
    filters: {
      hidden: (item) => !item.tags?.includes('hidden'),
    },
  },
})

Then we can hide a story by giving it the 'hidden' tag.

What I'm seeing though is that as soon as I hide a story, I can't see the controls anymore on that story's page. This seems like a bug, but please let me know if it's intended behavior.

To Reproduce

No response

System

Storybook Environment Info:

  System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M1 Pro
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.17.1 - ~/.nvm/versions/node/v18.17.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.17.1/bin/yarn
    npm: 9.6.7 - ~/.nvm/versions/node/v18.17.1/bin/npm
    pnpm: 7.33.6 - ~/.nvm/versions/node/v18.17.1/bin/pnpm <----- active
  Browsers:
    Chrome: 120.0.6099.234
    Edge: 120.0.2210.144
    Safari: 17.2.1
  npmPackages:
    @storybook/addon-a11y: ^7.5.3 => 7.5.3 
    @storybook/addon-actions: ^7.5.3 => 7.6.4 
    @storybook/addon-essentials: ^7.5.3 => 7.5.3 
    @storybook/addon-interactions: ^7.5.3 => 7.5.3 
    @storybook/addon-links: ^7.5.3 => 7.5.3 
    @storybook/blocks: ^7.5.3 => 7.5.3 
    @storybook/components: ^7.5.3 => 7.5.3 
    @storybook/core-events: ^7.5.3 => 7.5.3 
    @storybook/manager-api: ^7.5.3 => 7.5.3 
    @storybook/preview-api: ^7.5.3 => 7.5.3 
    @storybook/react: ^7.5.3 => 7.5.3 
    @storybook/react-vite: ^7.5.3 => 7.5.3 
    @storybook/testing-library: ^0.2.2 => 0.2.2 
    @storybook/theming: ^7.5.3 => 7.5.3 
    storybook: ^7.5.3 => 7.5.3 
    storybook-addon-a11y: ^3.1.9 => 3.1.9 
    storybook-addon-pseudo-states: ^2.1.2 => 2.1.2

Additional context

No response

Contributor guide