storybookjs/storybook

[Bug]: flow typecheck fails due to malformed_package_json

Open

#25202 opened on Dec 12, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
bugbuilder-webpack5compatibility with other toolshelp wanted

Description

Describe the bug

Flow responds with an error when I upgrade storybook to the latest version.

To Reproduce

Run npx storybook@latest upgrade on a project that had storybook@7.6.3 to update the storybook to 7.6.4. This was also a problem when I ran that script to update storybook from 7.5.3 to 7.6.3.

Run npx flow.

Error message:

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
node_modules/@storybook/preset-react-webpack/node_modules/resolve/test/resolver/malformed_package_json/package.json:2:1

Unexpected end of input, expected the token }

     1│ {
     2│



Found  1 error

System

ubuntu2004 and on a macbook pro with sonoma 14.1.2

Additional context

I looked up the file in the node_modules directory, and it just has a single open curly bracket.

Reverting @storybook/react-webpack5 to 7.5.3 resolves the flow error, but that package isn't kept in sync with the other storybook packages.

Running storybook locally works as expected with react-webpack5@7.6.4

Contributor guide

Tech stack
typescriptreactnodejs
Domain
frontendtoolingbuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of Flowfamiliarity with npm/yarnknowledge of Storybook package structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The bug is caused by a malformed package.json file inside node modules/@storybook/preset react webpack/node modules/resolve/test/resolver/malformed package json/. Investigate why this file exists and why it is shipped. Likely, the 'resolve' package's test artifacts are being included in production builds. Check the build configuration of the preset react webpack package and ensure that such test files are excluded. Additionally, verify if the malformed JSON is introduced during publishing or if it's a known issue with the resolve dependency. A fix could involve removing the test directory from the published package or patching the resolve package to not include malformed JSON.