storybookjs/storybook

[Bug]: Please try de-duplicating these dependencies by running pnpm dedupe

Open

#24734 opened on Nov 6, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
automigrationsbughelp wantedpnpmsev:S4

Description

Describe the bug

When running pnpm dlx sb upgrade, I get a migration summary of the following:

│   If you'd like to run the migrations again, you can do so by running 'npx storybook@next automigrate'                                  │
│                                                                                                                                         │
│   The automigrations try to migrate common patterns in your project, but might not contain everything needed to migrate to the latest   ││   version of Storybook.                                                                                                                 │
│                                                                                                                                         │
│   Please check the changelog and migration guide for manual migrations and more information:                                            ││   https://storybook.js.org/migration-guides/7.0                                                                                         │
│   And reach out on Discord if you need help: https://discord.gg/storybook                                                               │
│                                                                                                                                         │
│   ─────────────────────────────────────────────────                                                                                     │
│                                                                                                                                         │
│   You can find more information for a given dependency by running pnpm list --depth=1 <package-name>                                    │
│                                                                                                                                         │
│   Please try de-duplicating these dependencies by running pnpm dedupe

But, It didn't actually list out any duplicates.

To Reproduce

No response

System

Storybook Environment Info:

  System:
    OS: macOS 14.0
    CPU: (12) arm64 Apple M2 Max
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/Library/Caches/fnm_multishells/74712_1698693097514/bin/node
    npm: 9.5.1 - ~/Library/Caches/fnm_multishells/74712_1698693097514/bin/npm
    pnpm: 8.8.0 - ~/Library/Caches/fnm_multishells/74712_1698693097514/bin/pnpm <----- active
  Browsers:
    Safari: 17.0
  npmPackages:
    @storybook/addon-a11y: 7.6.0-alpha.4 => 7.6.0-alpha.4
    @storybook/addon-essentials: 7.6.0-alpha.4 => 7.6.0-alpha.4
    @storybook/addon-interactions: 7.6.0-alpha.4 => 7.6.0-alpha.4
    @storybook/jest: ^0.2.3 => 0.2.3
    @storybook/react: 7.6.0-alpha.4 => 7.6.0-alpha.4
    @storybook/react-vite: 7.6.0-alpha.4 => 7.6.0-alpha.4
    @storybook/test-runner: ^0.14.0-next.2 => 0.14.0-next.2
    @storybook/testing-library: ^0.2.2 => 0.2.2
    @storybook/types: 7.6.0-alpha.4 => 7.6.0-alpha.4
    chromatic: ^6.17.3 => 6.24.1
    eslint-plugin-storybook: ^0.6.15 => 0.6.15
    storybook: 7.6.0-alpha.4 => 7.6.0-alpha.4

Additional context

I've used pnpm.overrides to avoid duplicates already. Maybe that's why this is getting triggered?

Contributor guide

Tech stack
typescriptnodejs
Domain
clideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of Storybook CLI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the automigrate command in the Storybook CLI (likely in lib/cli) to find where the deduplication suggestion is generated. Check why the list of duplicates is not printed when pnpm.overrides are used. The issue reporter suggests that pnpm.overrides might bypass the duplicate detection. Look at the logic that enumerates duplicates and ensure it accounts for overrides.