storybookjs/storybook

[Bug]: Storybook launches in the wrong browser

Open

#22,929 opened on Jun 5, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
bugclihelp wantedsev:S4

Description

Describe the bug

On MacOS when my default browser is set to chrome, running start-storybook causes the storybook instance to launch in brave instead of chrome if both browsers are open.

To Reproduce

Open an instance of brave and chrome with chrome as your default browser. Run start-storybook and the storybook tab will be opened in brave instead of chrome.

System

Environment Info:

  System:
    OS: macOS 13.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 3.5.0 - ~/codebase/sf-ui-web/node_modules/.bin/yarn
    npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 114.0.5735.90
    Safari: 16.5

Additional context

No response

Contributor guide

Tech stack
typescriptnodejsshell
Domain
frontenddeveloper experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js basicsStorybook CLImacOS browser management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the start storybook command's browser opening logic. Look for calls to `open` or `opn` package in the Storybook source code. The bug likely occurs because the browser detection does not respect the system default browser when multiple browser instances are open. Check the macOS specific implementation in the `@storybook/core server` or `@storybook/cli` package for browser launching code. Consider using the `open` npm package or the `x www browser` approach on macOS.