storybookjs/storybook

[Bug]: migrate csf-2-to-3 does not work for CSF1

Open

#22,408 opened on May 5, 2023

View on GitHub
 (6 comments) (0 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
bugclihelp wantedsev:S4

Description

Describe the bug

After executing the command, the blank line of the file is deleted without any migration modification

 npx storybook@latest migrate csf-2-to-3 --glob="src/**/*.stories.js"

pic for result image image

To Reproduce

No response

System

Environment Info:

  System:
    OS: macOS 12.3.1
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 16.13.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.1.2 - /usr/local/bin/npm
  Browsers:
    Chrome: 112.0.5615.137
    Firefox: 110.0.1
    Safari: 15.4
  npmPackages:
    @storybook/addon-actions: ^7.0.7 => 7.0.8
    @storybook/addon-console: ^1.2.3 => 1.2.3
    @storybook/addon-links: ^7.0.7 => 7.0.8
    @storybook/addons: ^7.0.7 => 7.0.8
    @storybook/cli: ^7.0.7 => 7.0.8
    @storybook/client-api: ^7.0.7 => 7.0.8
    @storybook/react: ^7.0.7 => 7.0.8
    @storybook/react-webpack5: ^7.0.7 => 7.0.8
    @storybook/theming: ^7.0.7 => 7.0.8

Additional context

No response

Contributor guide

Tech stack
typescriptnodejs
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic understanding of Storybook's CSF formatFamiliarity with Node.js CLI tools
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the csf 2 to 3 migration script in the Storybook repository. Look for the codemod package (likely under `code/lib/codemod` or similar) and examine how it processes CSF1 stories. Check if the migration incorrectly handles blank lines or fails to apply transformations to old format stories. Review the issue comments for any additional context or reproduction steps provided by maintainers. Attempt to reproduce the bug with a minimal CSF1 story file to identify the exact failure point.