storybookjs/storybook

[Feature Request]: Drop dependency on `browser-assert`

Open

#21,408 opened on Mar 6, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
help wantedmaintenancesecurity

Description

Is your feature request related to a problem? Please describe

The package browser-assert which @storybook/builder-manager and @storybook/builder-webpack5 depend on has various issues according to: https://socket.dev/npm/package/browser-assert

Describe the solution you'd like

Remove the unmaintained dependency and write the 7 LOC yourself or use native methods.

Describe alternatives you've considered

No response

Are you able to assist to bring the feature to reality?

no

Additional context

No response

Contributor guide

Tech stack
typescriptnodejs
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptnpm dependency managementStorybook project structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Locate the dependency declaration of `browser assert` in the package.json files of `@storybook/builder manager` and `@storybook/builder webpack5`. Search for imports of `browser assert` in the source code of these packages. Implement a small function that replicates the 7 line functionality (likely a simple boolean check for browser context). Remove the dependency from package.json and run the tests to ensure nothing breaks. The issue has 1 comment; check it for any additional guidance. If the replacement is straightforward, submit a PR removing the dependency.