storybookjs/storybook

Feature: Storybook doesn't show an error for a story file with Meta but no stories

Open

#21,375 opened on Mar 3, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
feature requesthelp wantedstory index

Description

Describe the bug

If you create a sandbox e.g. npx storybook@next sandbox then run Storybook

Then modify the contents of the Button.stories file to only this:

export default {
  title: 'Hello',
}

or

import { Button } from './Button'
export default {
  component: Button
}

Storybook will not display any errors in the CLI or in the browser, and the Button component will not be visible in the sidebar:

Additionally, you get the same behavior if you change the contents of the story file to be:

import { Button } from './Button'
export default {
  component: Button,
  excludeStories: 'Default'
}

export const Default = {}

Contributor guide

Tech stack
typescriptreact
Domain
frontendtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Storybook CSFBasic knowledge of JavaScript/TypeScriptFamiliarity with how Storybook indexes stories
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the story indexer in `lib/core server/src/utils/story index.ts` or similar to see how story exports are validated. The issue occurs when a default export (Meta) exists without any named story exports. Add a warning or error when no story exports are found. Check existing validation in the `normalizeStory` or `processStories` functions. Look at how the sidebar builds from the index to ensure missing stories are flagged.