storybookjs/storybook

[Bug] When using argTypes the component type should be loosened.

Open

#20,889 opened on Feb 2, 2023

View on GitHub
 (0 comments) (1 reaction) (1 assignee)TypeScript (89,909 stars) (10,058 forks)batch import
argtypesbughelp wantedsev:S3typescript

Description

For example, you may want to drop an arg in your argTypes:

Image

Or you want to use arg mapping:

Image

In this case, we could drop the constraints we put on the "component" of meta.

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript genericsStorybook meta/argTypes structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the type definitions for `component` in the `Meta` type within Storybook's core packages. Look at the `@storybook/types` package or the relevant source files under `lib/types` or `core/types`. The issue requests loosening the type constraint on `component` in `argTypes`. Examine how `Component` is currently defined and used in `Meta` and related types. Since there is an assignee, check if any branch or draft PR exists. The fix likely involves changing the type parameter or using a less restrictive type like `any` or a generic type that accommodates different component signatures.