storybookjs/storybook

Explore replacing express with fastify in dev server

Closed

#17,971 opened on Apr 15, 2022

View on GitHub
 (18 comments) (3 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
feature requesthelp wanted

Description

Is your feature request related to a problem? Please describe Serving content via http2 is beneficial and greatly improves load times when serving many files. This is the case when using using a no-bundler such as the builder-vite plugin

When using builder-vite, file count can easily exceed 1k files. This causes load times to be 🐌 . We can alleviate this by enabling http2 when appropriate.

Describe the solution you'd like When running storybook with https enabled:

# optionally we can also autogenerate the selfsigned cert
# maybe take inspiration from the selfsigned package on npm
start-storybook --https --ssl-cert selfsigned.crt --ssl-key selfsigned.key

storybook assets are served via http2

Describe alternatives you've considered Accept http1.1 bottleneck

Are you able to assist to bring the feature to reality? yes, I can...

Additional context

Contributor guide

Tech stack
typescriptexpressnodejsvite
Domain
backendperformancedeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsExpressHTTP/2Storybook dev server architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the current dev server implementation in Storybook's `lib/core server` directory, which uses Express. Evaluate Fastify as a replacement, focusing on its built in HTTP/2 support and compatibility with existing middleware. Review the issue comments for any design discussions or obstacles raised. Consider automatically generating self signed certificates for HTTPS as suggested.