stereobooster/react-snap

Crawl only html documents

Open

#339 opened on Feb 28, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (4,982 stars) (403 forks)batch import
enhancementhelp wanted

Description

Feature Request

Is your feature request related to a problem? Please describe. Puppeteer does not handle PDF files. react-snap will crawl to them if links exist and the process will crash. There doesn't seem to be a way to ignore this.

Describe the solution you'd like I'd like the ability to be able to specify files/paths/globs to ignore as an option.

Describe alternatives you've considered I've looked at other snapshot libraries but prefer this one. I've looked at whether it's possible to pass an argument to puppeteer to handle this but it doesn't seem to be.

Teachability, Documentation, Adoption, Migration Strategy I'd imagine an option in package.json, like:

ignore: ["**.pdf"]

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingfrontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptUnderstanding of glob patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests adding an `ignore` option to skip certain file extensions during crawling. Look at the crawling logic in `src/` or `index.js` to see how links are followed. Implement a configurable ignore list (e.g., `ignore: ['**.pdf']`) and update the relevant crawling function to skip matches. Check existing tests for examples of how options are handled.