stereobooster/react-snap

Disable Service Workers

Open

#314 opened on Dec 9, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (403 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,982 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Feature Request

Is your feature request related to a problem? Please describe. More people recently mentioned that there are issue with serviceWorkers. I guess Chromium changed behaviour of serviceWorkers recently. As far as I remember they only worked over https, but now they work over http for localhost.

Describe the solution you'd like Do the same as minimalcss https://github.com/peterbe/minimalcss/issues/223

Describe alternatives you've considered none

Teachability, Documentation, Adoption, Migration Strategy should be minor version change

Contributor guide

Research direction
Review the linked minimalcss issue for implementation details on disabling service workers. Then modify the react snap configuration to add an option to disable service workers during prerendering.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70