stereobooster/react-snap

Disable Service Workers

Open

#314 opened on Dec 9, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (4,982 stars) (403 forks)batch import
enhancementhelp wanted

Description

Feature Request

Is your feature request related to a problem? Please describe. More people recently mentioned that there are issue with serviceWorkers. I guess Chromium changed behaviour of serviceWorkers recently. As far as I remember they only worked over https, but now they work over http for localhost.

Describe the solution you'd like Do the same as minimalcss https://github.com/peterbe/minimalcss/issues/223

Describe alternatives you've considered none

Teachability, Documentation, Adoption, Migration Strategy should be minor version change

Contributor guide

Tech stack
javascriptreactnodejs
Domain
frontendtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with service workersUnderstanding of react snap configurationBasic JavaScriptGit/PR workflow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Review the referenced minimalcss issue (#223) for implementation pattern. Investigate react snap's current service worker generation logic (likely in the build output step). Propose a new configuration option (e.g., 'disableServiceWorker') that skips the service worker file generation. Discuss with maintainers on the desired API and documentation.