stenciljs/eslint-plugin

bug: own-methods-must-be-private enforces `private` accessor on `#name` while typescript disallowes it

Open

#125 opened on Nov 27, 2024

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (37 forks)auto 404
Help Wanted

Repository metrics

Stars
 (71 stars)
PR merge metrics
 (PR metrics pending)

Description

Prerequisites

Stencil ESLint Version

0.8.0

Current Behavior

When using fields and methods marked with private identifier # like #methodName we get warning from eslint, triggering the rule ESLint: Own class methods cannot be public(@stencil-community/ own-methods-must-be-private), the fix is to add the private modifier. This on the other hand fails with typescript TS18010: An accessibility modifier cannot be used with a private identifier.

Expected Behavior

Have eslint recognize names starting with # as being private, and don't report violation.

Steps to Reproduce

Have a simple component like:

@Component({/*...*/})
class foo{
#someName(){ /*...*/ }
}

Eslint will try to add the private keyword, but then typescript reports invalid syntax.

Code Reproduction URL

no url

Additional Information

No response

Contributor guide

Research direction
Examine the rule 'own methods must be private' in the source code, specifically how it identifies private methods. The fix should ensure that methods using private identifier (#) are recognized as private and not flagged.
Tech stack
typescript
Domain
toolingdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptTypeScriptESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80