Buffer getter methods return internal references instead of copies

Open Beginner friendly
#538 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
go
Domain
backend

Research direction

Start in internal/indexer/indexer_buffer.go and compare GetTrustlineChanges(), GetContractChanges(), GetAccountChanges(), GetSACBalanceChanges(), and GetStateChanges() with GetTransactionsParticipants(), which uses maps.Clone(). Done means all five listed getters return copies rather than direct references to internal data structures.

Written by the indexing model from the issue text.

Description

bug
What version are you using?

latest

Problem

File: internal/indexer/indexer_buffer.go (multiple methods)

Description: GetTrustlineChanges(), GetContractChanges(), GetAccountChanges(), GetSACBalanceChanges(), and GetStateChanges() return direct references to internal data structures. Compare with GetTransactionsParticipants() which correctly uses maps.Clone(). While currently safe because data is consumed synchronously before Clear(), this violates the buffer's thread-safety contract and is fragile.

Dominant language
Go
Stars
30
Forks
23
Avg merge
6d 2h
Merged PRs (30d)
20

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stellar/wallet-backend

All issues in stellar/wallet-backend

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.