stefalda/ReactNativeLocalization

string keys support

Open

#32 opened on Jun 12, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (891 stars) (119 forks)batch import
enhancementhelp wanted

Description

Hello, I don't know if it's done specially, but string keys are not supported. Wouldn't it be more logical to write:

Hello {title}, you have ${amount} on your balance

and then

strings.formatString(strings.foo, {title : 'Mr', amount: 10000000})

?

Contributor guide

Tech stack
reactreact nativejavascript
Domain
frontendmobileinternationalization
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with ReactNativeLocalizationJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the current format string parsing in the library's main source file (likely index.js or similar). The issue proposes supporting named keys (e.g., {title}) instead of positional placeholders. Check the comments on the issue for any additional context or suggestions. Modify the parse function to extract named keys from the format string and replace them with corresponding values from the provided object. Ensure backward compatibility with existing positional usage.