stefalda/ReactNativeLocalization

string keys support

Open

#32 opened on Jun 12, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (119 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (891 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello, I don't know if it's done specially, but string keys are not supported. Wouldn't it be more logical to write:

Hello {title}, you have ${amount} on your balance

and then

strings.formatString(strings.foo, {title : 'Mr', amount: 10000000})

?

Contributor guide

Research direction
Study how the library currently handles placeholder replacement and extend it to support string keys via a dictionary object.
Tech stack
javascriptreactreact native
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React NativeGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75