Fix C lint errors

Open Beginner friendly
#13,417 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
c
Domain
tooling

Research direction

Start with lib/node_modules/@stdlib/ndarray/base/assert/is-contiguous/src/main.c at the stdlib_ndarray_is_contiguous signature identified in workflow run 29132267579. Review the reported shape and strides constParameterPointer warnings, then run the C lint workflow or its local equivalent; done means the reported lint errors no longer occur.

Written by the indexing model from the issue text.

Description

C Linting Failures

Linting failures were detected in the automated lint workflow run.

Workflow Details
Error Details
lib/node_modules/@stdlib/ndarray/base/assert/is-contiguous/src/main.c:51:95: style: Parameter 'shape' can be declared as pointer to const [constParameterPointer]
int8_t stdlib_ndarray_is_contiguous( enum STDLIB_NDARRAY_DTYPE dtype, int64_t ndims, int64_t *shape, int64_t *strides, int64_t offset ) {
                                                                                              ^
lib/node_modules/@stdlib/ndarray/base/assert/is-contiguous/src/main.c:51:111: style: Parameter 'strides' can be declared as pointer to const [constParameterPointer]
int8_t stdlib_ndarray_is_contiguous( enum STDLIB_NDARRAY_DTYPE dtype, int64_t ndims, int64_t *shape, int64_t *strides, int64_t offset ) {
                                                                                                              ^
Pull Request Instructions
  • Please use the following PR title format:
    "chore: fix C lint errors (issue #<ISSUE_NUMBER>)".
  • Reference this issue in the "Related Issues" section of the PR body as "resolves #<ISSUE_NUMBER>".
Dominant language
JavaScript
Stars
6k
Forks
1.3k
Avg merge
1d 1h
Merged PRs (30d)
559

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stdlib-js/stdlib

All issues in stdlib-js/stdlib

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.