base_nuts.hpp:110 — Unnecessary .transpose() on column vector
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 86/100
Research direction
Review base_nuts.hpp around line 110, focusing on the assignment from z_.p to rho. Confirm that rho uses the VectorXd directly without transpose and that the change compiles successfully under strict Eigen assertions.
Written by the indexing model from the issue text.
Description
Eigen::VectorXd rho = this->z_.p.transpose();
z_.p is a VectorXd (D×1). .transpose() produces a RowVectorXd (1×D), which is
then assigned to a VectorXd (D×1). This works due to Eigen's dynamic resizing
but could trigger debug assertions in strict Eigen builds. Should just be rho
= this->z_.p;.
- Dominant language
- C++
- Stars
- 2.8k
- Forks
- 388
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 15
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from stan-dev/stan
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 66/100
-
algorithm code cleanup help wanted
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
good first issue i/o interface
Difficulty 3/5 1-2 days Newbie friendliness 65/100
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·