stan-dev/stan

Clean up code: `.str().length()`

Open

#2,577 opened on Jul 10, 2018

View on GitHub
 (13 comments) (0 reactions) (1 assignee)R (1,476 stars) (270 forks)batch import
code cleanupgood first issue

Description

Summary:

There are many instances of code that looks like:

if (msg.str().length() > 0)
  logger.info(msg);

We should either:

  • have the info() method ignore empty messages in general
  • wrap the call in a function

Additional Information:

Originally from this PR comment: https://github.com/stan-dev/stan/pull/2570#discussion_r201151286

Current Version:

v2.17.1

Contributor guide

Tech stack
cpp
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++Stan codebase structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
First, review the PR comment at https://github.com/stan dev/stan/pull/2570#discussion r201151286 to understand the original suggestion. Then, examine the `info()` method in the logging implementation (likely in a header file like `src/stan/model/logging.hpp`) to decide whether to modify it to ignore empty strings or to create a helper function. Finally, search for all occurrences of the `.str().length() > 0` pattern in the codebase and apply the chosen fix.