stan-dev/stan

Clean up code: `.str().length()`

Open

#2,577 opened on Jul 10, 2018

View on GitHub
 (13 comments) (0 reactions) (1 assignee)R (270 forks)batch import
code cleanupgood first issue

Repository metrics

Stars
 (1,476 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Summary:

There are many instances of code that looks like:

if (msg.str().length() > 0)
  logger.info(msg);

We should either:

  • have the info() method ignore empty messages in general
  • wrap the call in a function

Additional Information:

Originally from this PR comment: https://github.com/stan-dev/stan/pull/2570#discussion_r201151286

Current Version:

v2.17.1

Contributor guide

Research direction
Identify all occurrences of the pattern `if (msg.str().length() > 0) logger.info(msg);` in the codebase. Evaluate two approaches: (1) modify the info() method to ignore empty messages, or (2) wrap the pattern in a helper function. Implement the chosen solution consistently and update tests accordingly.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60