stacks-network/stacks-core

Node always logs "Proceeding to mine blocks" regardless of miner status

Open

#4,944 opened on Jul 2, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (758 forks)auto 404
enhancementgood first issuestale

Repository metrics

Stars
 (3,063 stars)
PR merge metrics
 (PR metrics pending)

Description

On a follower node, I see the following as expected:

INFO [1719960965.695137] [testnet/stacks-node/src/run_loop/neon.rs:384] [main] Will run as a Follower node

However, shortly after I also see:

INFO [1719960987.613683] [testnet/stacks-node/src/run_loop/neon.rs:1341] [main] Runloop: Synchronized full burnchain up to height 850443. Proceeding to mine blocks

This is confusing and incorrect, since this node is not a miner.

The code in question doesn't have any conditionals around miner status for this log message: https://github.com/stacks-network/stacks-core/blob/master/testnet/stacks-node/src/run_loop/nakamoto.rs#L705

Contributor guide

Research direction
Add a conditional check for miner status before logging the message.
Tech stack
rust
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90