stackabletech/tokio-zookeeper

[Suggestion] Use tokio_codec

Open

#1 opened on Jul 11, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Rust (22 forks)auto 404
help wanted

Repository metrics

Stars
 (77 stars)
PR merge metrics
 (PR metrics pending)

Description

I was looking for an example of how to make a reusable tcp client with Tokio, and this seems to be the only example in the wild that I can actually find, so thank you. This will hopefully be helpful for my own project.

I was wondering why you do not use tokio_codec to handle the bytes serialization/deserialization. I think it might be easier to read if you use the Encoder/Decoder traits to separate those concerns into their own instead of mixing them into polling.

Contributor guide

Research direction
Review the current TCP client implementation, especially how bytes are read and written in the polling loop. Explore the tokio codec crate and its Encoder/Decoder traits. Identify the serialization/deserialization logic that could be extracted into a codec. Compare with examples using tokio codec for reference.
Tech stack
rust
Domain
networkingbackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRustBasic Tokio knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65