No validation that the connection target is a Trino instance

Open
#308 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
58/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
api, backend

Research direction

Start with src/routes/(app)/trino/+page.server.ts and trace how the query action handles configured connection URLs and new connections. Check how calling Trino's /v1/info endpoint can distinguish a Trino server, then verify that non-Trino responses are rejected before SQL is sent.

Written by the indexing model from the issue text.

Description

File: src/routes/(app)/trino/+page.server.ts

The query action sends whatever SQL the user provides to the configured connection URL without first verifying that the endpoint is actually a Trino instance. A user could point the URL at any HTTP server, and the app would blindly POST to it. We should validate new connections (e.g. by calling Trino's /v1/info endpoint) and reject URLs that do not respond as a Trino server.

Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
22h 6m
Merged PRs (30d)
12

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stackabletech/cockpit

All issues in stackabletech/cockpit

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.