TLS certificate verification can be disabled without a custom CA

Open
#305 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
52/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
backend, security

Research direction

Start in src/lib/server/storage/s3-client.ts by tracing how tls.verification is read and how the S3 client is created. Identify where a PEM CA bundle could be supplied and confirm the existing insecure behavior is no longer needed. Done means private-CA certificates are validated without disabling TLS verification, while the supported configuration remains clear.

Written by the indexing model from the issue text.

Description

File: src/lib/server/storage/s3-client.ts

When tls.verification is set to 'None', the S3 client is created with rejectUnauthorized: false, disabling certificate validation entirely. This is a blunt instrument: it silences errors from self-signed or expired certificates but also makes the connection vulnerable to MITM attacks. The correct long-term fix is to allow users to provide their own CA bundle (a PEM file) which is then used to create a custom TLS context, so the server certificate is still validated — just against a trusted private CA instead of the public root store.

Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
22h 6m
Merged PRs (30d)
12

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stackabletech/cockpit

All issues in stackabletech/cockpit

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.