square/sqlbrite

Lint checks for runtime assertions and common errors.

Open

#58 opened on Sep 9, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (431 forks)batch import
help wantedicebox

Repository metrics

Stars
 (4,578 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

  • Creating a query inside of a transaction
  • Question marks in a query don't match number of arguments (#220)
  • Missing mark success in try/finally or try-with-resources
  • Multiple insert/update/delete statements not in a transaction in a single method
  • Ensure first argument looks like a table / list of tables
  • Second argument looks like SQL and contains all tables from the first argument

Contributor guide

Research direction
Examine the existing lint checks in the project (if any) and understand the pattern used. For each unchecked checkbox, design and implement a custom lint rule following the same pattern. Start by looking at the checked items to see what was done for those.
Tech stack
java
Domain
databasemobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70