Using `.pre-commit-config` as a linter and test link check
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
Research direction
The issue proposes a .pre-commit-config using pre-commit-hooks, isort with the black profile, and flake8; begin by checking the repository's current lint and test workflow. Done means the agreed hooks run successfully and new pull requests are checked against the project's linting rules.
Written by the indexing model from the issue text.
Description
I guess pre-commit is a good suggestion to let the project clean, and also check the new PRs if they correspond to the linting rules.
For example:
- I use https://github.com/pre-commit/pre-commit-hooks for checking:
hooks:
- id: check-merge-conflict
- id: check-added-large-files
- id: check-ast
- id: check-symlinks
- id: trailing-whitespace
- id: check-json
- id: debug-statements
- id: pretty-format-json
- For sorting imports, I use https://github.com/PyCQA/isort with the black profile.
- I use https://gitlab.com/pycqa/flake8 also for applying all style rules.
I will try to describe this issue in a PR.
- Dominant language
- Python
- Stars
- 459
- Forks
- 90
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sqlalchemy/mako
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
sqlalchemy/mako#432 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
sqlalchemy/mako#417 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
sqlalchemy/mako#392 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
sqlalchemy/mako#382 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
sqlalchemy/mako#376 · 9 comments ·
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100