Autogenerate migration still has minor typing issues with mypy
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
Research direction
Start by reviewing the fix for issue #1253 and the autogenerate migration code where down_revision is typed. Check the annotation with mypy, including merge revisions where down_revision is a tuple. Done means the type accepts str, Sequence[str], and None without typing errors.
Written by the indexing model from the issue text.
Description
The fix for #1253 looks slightly incorrect as the type for down_revision should be Union[str, Sequence[str], None] and not Union[str, None]. down_revision is a tuple for merge revisions.
- Dominant language
- Python
- Stars
- 4.4k
- Forks
- 375
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sqlalchemy/alembic
-
autogenerate - detection bug open for pull requests
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
sqlalchemy/alembic#1121 · 3 comments ·
-
autogenerate - defaults missing behavior postgresql
Difficulty 4/5 3-5 days Newbie friendliness 48/100
sqlalchemy/alembic#1837 · 10 comments ·
-
batch migrations feature great mcve naming convention issues sqlite
Difficulty 5/5 Over a week Newbie friendliness 45/100
sqlalchemy/alembic#1834 · 1 comment ·
-
autogenerate - rendering execution model use case
Difficulty 4/5 3-5 days Newbie friendliness 48/100
sqlalchemy/alembic#1825 · 1 comment ·
-
Proposal: First‑class Alembic support for Views (incl. Materialized) + Routines for ETL/PostGIS Openuse case
Difficulty 5/5 Over a week Newbie friendliness 30/100
sqlalchemy/alembic#1797 · 2 comments ·
All issues in sqlalchemy/alembic
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100