Adding the series extension
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript, sqlite, wasm
- Domain
- api, build-system, database
Research direction
Start with the Makefile, src/exported_functions.json, and src/api.js to trace how series.c is built and initialized. Run test/test_generate_series.js and inspect the reported signature mismatch. Done means the SQLite build initializes the series extension successfully and the generate_series tests pass.
Written by the indexing model from the issue text.
Description
Hello 👋
I'm trying to add the generate_series function from the series extension to the SQLite build.
At the moment, here is what I have done so far:
- modify the Makefile so it downloads the series.c file automatically and puts it in the sql-amalgation folder.
- modify the Makefile so it builds the
series.cfile and add it to thewasmoutput. - include the
_sqlite3_series_initfunction to thesrc/exported_functions.jsonfile - (this is where it errors) modify the
src/api.jsfile so it calls thesqlite3_series_initfunction
I read #459 and it seems like we had to do this...?
when running the tests, I'm getting the following error:
⚡ RuntimeError: function signature mismatch
at sqlite3_series_init (<anonymous>:wasm-function[2577]:0x82a1e)
at Module._sqlite3_series_init (/workspaces/sql.js/dist/sql-wasm.js:6140:105)
at new Database (/workspaces/sql.js/dist/sql-wasm.js:937:22)
at Object.exports.test (/workspaces/sql.js/test/test_generate_series.js:4:14)
at test generate series (/workspaces/sql.js/test/test_generate_series.js:22:17)
at test (/workspaces/sql.js/node_modules/test/test.js:29:20)
at next (/workspaces/sql.js/node_modules/test/test.js:69:7)
at suite (/workspaces/sql.js/node_modules/test/test.js:71:5)
at Object.run (/workspaces/sql.js/node_modules/test/test.js:87:3)
at /workspaces/sql.js/test/test_generate_series.js:20:21
Here is my fork with all the modifications I have made: https://github.com/Androz2091/sql.js
Can someone help me to understand? Maybe @twoxfh, and @rhashimoto, who solved the issue #459?
- Dominant language
- JavaScript
- Stars
- 13.7k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sql-js/sql.js
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·