initSqlJs doesn't throw when wasm cannot be fetched

Open
#491 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, wasm
Domain
database, web-dev

Research direction

Start at the initSqlJs entry point and reproduce the case where the WASM file cannot be fetched. Trace the fetch error through initialization and ensure the returned promise rejects rather than remaining pending; verify the failure is observable to the caller.

Written by the indexing model from the issue text.

Description

import initSqlJs from 'sql.js';

(async () => {
  await initSqlJs();
})();

The promise will never settle, if the file cannot be fetched. The console will output

Uncaught (in promise) TypeError: Failed to fetch

but the promise remains in the "pending" state, so I guess the fetch is running outside the normal promise chain

Dominant language
JavaScript
Stars
13.7k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sql-js/sql.js

All issues in sql-js/sql.js

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.