Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Carriage return not added

Open
#925 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java, spring
Domain
cli

Research direction

Start at the finishInteractiveShell entry point shown in the issue and reproduce the sequence in the Jenkins test run, paying attention to the three .cr() calls and the output where the two y values share a line. Done means the session consistently adds the expected carriage return after each submitted value across the test run.

Written by the indexing model from the issue text.

Description

status/need-triage

Just before ending a session. I always print the last few lines in the terminal:

    protected static void finishInteractiveShell(InteractiveShellSession session, Path outputFile, boolean verify, boolean submit) {
        session.write(session.writeSequence().text(outputFile.toString()).cr().build());
        session.write(session.writeSequence().text(verify ? "y" : "n").cr().build());
        session.write(session.writeSequence().text(submit ? "y" : "n").cr().build());
    }

I run my tests in Jenkins and there is around 100 tests. This is flaky and sometimes it breaks as it doesn't add the carriage return after each line of code .cr().

Here is the output in the Jenkins build you can see the two y added at the end of the same line.

? Select an action: [Use arrows to move], filtering 'finish/tmp/junit10400994433265716921/TYPEZTUUTCOLAJ.jsonyy' 
Dominant language
Java
Stars
826
Forks
405
Avg merge
6d 9h
Merged PRs (30d)
1

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from spring-projects/spring-shell

All issues in spring-projects/spring-shell

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.