RegexRequestMatcher.matches() allocates LogMessage wrapper on every request even when debug disabled

Open Beginner friendly
#19,251 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
java, spring
Domain
backend, security

Research direction

Start in web/src/main/java/org/springframework/security/web/util/matcher/RegexRequestMatcher.java at line 136 and inspect the logging in matches(). Confirm the LogMessage wrapper is not allocated when debug logging is disabled while request matching remains unchanged, then validate the change with the relevant project tests.

Written by the indexing model from the issue text.

Description

status: waiting-for-triage type: bug

Describe the bug
web/src/main/java/org/springframework/security/web/util/matcher/RegexRequestMatcher.java:136 allocates memory and wastes CPU when debug logging is disabled - a typical production scenario.

OrRequestMatcher.matches calls every child matcher per request, so this multiplies by the number of regex rules in the security config.

Proposed fix: wrap with isDebugEnabled()

Stacktrace:

  org.springframework.core.log.LogMessage$FormatMessage2.<init>(String, Object, Object)
  org.springframework.core.log.LogMessage.format(String, Object, Object)
  org.springframework.security.web.util.matcher.RegexRequestMatcher.matches(HttpServletRequest)
  org.springframework.security.web.util.matcher.OrRequestMatcher.matches(HttpServletRequest)
  org.springframework.security.web.DefaultSecurityFilterChain.matches(HttpServletRequest)
  org.springframework.security.web.FilterChainProxy.getFilters(HttpServletRequest)
  org.springframework.security.web.FilterChainProxy.doFilterInternal(ServletRequest, ServletResponse, FilterChain)
  org.springframework.security.web.FilterChainProxy.doFilter(ServletRequest, ServletResponse, FilterChain)
Image
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from spring-projects/spring-security

All issues in spring-projects/spring-security

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.