SqlWindowingPagingQueryProvider does not generate correct SQL for Oracle [BATCH-2166]

Open Beginner friendly
#1,430 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
java, spring, sql
Domain
backend, database

Research direction

Locate SqlWindowingPagingQueryProvider and its getSubQueryAlias() method, then compare the generated Oracle SQL with the examples in the issue and the behavior from version 2.0.4. Done means first-page and remaining-page queries use the correct Oracle subquery alias syntax without AS.

Written by the indexing model from the issue text.

Description

in: infrastructure status: waiting-for-reporter type: bug

Philippe BAYE opened BATCH-2166 and commented

The generated SQL requests look like this (for both first page & remaining pages) :
SELECT * from (....) AS TMP_SUB WHERE ...

But for Oracle, the correct SQL requests look like this :
SELECT * from (....) TMP_SUB WHERE ...

The problem is located in the getSubQueryAlias() method.

In previous version (2.0.4) the SQL requests are corrected.

Affects: 2.1.9

Dominant language
Java
Stars
3k
Forks
2.5k
Avg merge
6d 53m
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from spring-projects/spring-batch

All issues in spring-projects/spring-batch

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.