spring-cloud/spring-cloud-netflix

RequestSpecificRetryHandler retries same server for SERVER_THROTTLED

Open

#2,585 opened on Dec 27, 2017

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Java (4,805 stars) (2,433 forks)batch import
help wanted

Description

Netflix's RequestSpecificRetryHandler allows to retry on same server for SERVER_THROTTLED error.

When the okToRetryOnAllErrors property is true, the retry handler allows to retry on the same server unconditionally without taking into account the actual error. This is useless when the server responded with SERVER_THROTTLED.

It looks like the if statement at https://github.com/Netflix/ribbon/blob/master/ribbon-core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java#L58-L65 should be considered first before the other conditions.

I doubt Netflix is willing to change this behavior but we could override it in SpringCloud. What do you think ?

Contributor guide

Tech stack
java
Domain
backendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaUnderstanding of Ribbon retry handlersSpring Cloud Netflix basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue identifies a bug in RequestSpecificRetryHandler where the okToRetryOnAllErrors flag overrides the specific check for SERVER THROTTLED, causing retries on the same server. The proposed fix is to reorder the if statement at lines 58-65 in ribbon core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java to check SERVER THROTTLED first. Examine how Spring Cloud Netflix customizes retry logic, possibly via a custom retry handler, and review the issue comments for maintainer consensus.