spring-cloud/spring-cloud-gateway

Request headers can not be modified after request pass through ModifyRequestBodyGatewayFilter

Open

#2,548 opened on Mar 11, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (4,284 stars) (3,204 forks)batch import
documentationhelp wanted

Description

Describe the bug Spring cloud version:3.0.3 I am using ModifyRequestBodyGatewayFilter to cache request body, but when request pass through ModifyRequestBodyGatewayFilter, heads can not be modified any more, at opposite, headers can be modified before ModifyRequestBodyGatewayFilter.

I guess this problem happened because decorate method from ModifyRequestBodyGatewayFilterFactory. Spring cloud gateway user can not get new headers from MutatedServerHttpRequest but can only get header from the time point when decorate method be called. image

I am not sure this is an issue or it's a mistake about my usage.

Contributor guide

Tech stack
java
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaSpring FrameworkSpring Cloud GatewayReactive programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the `decorate` method in `ModifyRequestBodyGatewayFilterFactory` to understand how headers are captured. Check the `MutatedServerHttpRequest` implementation to see if header mutations after decoration are ignored. Look for related issues or commits in the repository that may address header modification order. Consider whether the fix requires exposing headers from the mutated request or adjusting the filter order.
Request headers can not be modified after request pass through ModifyRequestBodyGatewayFilter · spring-cloud/spring-cloud-gateway#2548 | Good First Issue