spring-cloud/spring-cloud-gateway

Allow making replenishRate float?

Open

#2,145 opened on Feb 13, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (3,204 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,284 stars)
PR merge metrics
 (Avg merge 1d 21h) (18 merged PRs in 30d)

Description

Hello! In some cases it can be useful to make replenishRate float (special cases when 0<replenishRate< 1). So we will be able for example to increase value in the bucket by values < 1 every second (so value 0.1 means to fulfill bucket with 1 token every 10 seconds).

No code changes has be made for lua script to do this, only for config class.

https://github.com/spring-cloud/spring-cloud-gateway/blob/16808fbef751404192edc1d66b52fac6defcd9fb/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/ratelimit/RedisRateLimiter.java#L318

Contributor guide

Research direction
Examine the RedisRateLimiter config class to change the replenishRate field from int to double or float, and verify the Lua script handles float correctly.
Tech stack
java
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSpring
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60