spring-cloud/spring-cloud-gateway

Validate route uri

Open

#131 opened on Dec 12, 2017

View on GitHub
 (14 comments) (0 reactions) (0 assignees)Java (3,204 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,284 stars)
PR merge metrics
 (Avg merge 1d 21h) (18 merged PRs in 30d)

Description

Writeup and example: https://github.com/RyanBard/scg-npe

spring-cloud-gateway version: 2.0.0.M5 spring-boot-version: 2.0.0.M7

I'm getting a NullPointerException in NettyRoutingFilter on line 67 because scheme is null. It's possible that my configuration in my application.yml is bogus (the uri and predicate Path do not match -- EDIT: I've verified that it still fails for the same reason even if they do overlap), however, it looks like the overwriting of scheme in the UriComponentsBuilder calls in RouteToRequestUrlFilter could be problematic in other situations.

I would appreciate if you could take a look.

Thank you

Contributor guide

Research direction
Investigate the NullPointerException in NettyRoutingFilter line 67 by examining the route configuration in application.yml and the UriComponentsBuilder calls in RouteToRequestUrlFilter to understand when scheme becomes null.
Tech stack
javaspring
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSpring
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60