spring-cloud/spring-cloud-gateway

Validate route uri

Open

#131 opened on Dec 12, 2017

View on GitHub
 (14 comments) (0 reactions) (0 assignees)Java (4,284 stars) (3,204 forks)batch import
enhancementhelp wanted

Description

Writeup and example: https://github.com/RyanBard/scg-npe

spring-cloud-gateway version: 2.0.0.M5 spring-boot-version: 2.0.0.M7

I'm getting a NullPointerException in NettyRoutingFilter on line 67 because scheme is null. It's possible that my configuration in my application.yml is bogus (the uri and predicate Path do not match -- EDIT: I've verified that it still fails for the same reason even if they do overlap), however, it looks like the overwriting of scheme in the UriComponentsBuilder calls in RouteToRequestUrlFilter could be problematic in other situations.

I would appreciate if you could take a look.

Thank you

Contributor guide

Tech stack
javaspring
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaSpring Framework basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the NullPointerException in NettyRoutingFilter line 67 due to null scheme. Review the linked example repo (https://github.com/RyanBard/scg npe) and the RouteToRequestUrlFilter logic in the same codebase. Consider adding validation of the route URI or handling null scheme gracefully. Check existing comments for any proposed fixes or discussion.