spring-cloud/spring-cloud-gateway

Provide Kotlin Extension Functions (with reified type) for GatewayFilterSpec

Open

#1,252 opened on Aug 18, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (4,284 stars) (3,204 forks)batch import
enhancementhelp wanted

Description

GatewayFilterSpec (https://github.com/spring-cloud/spring-cloud-gateway/blob/master/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/route/builder/GatewayFilterSpec.java) has the Java methods modifyRequestBody and modifyResponseBody with arguments of type Class<T>. It would be nice to have Kotlin Extension Functions with reified types just as implemented by @sdeleuze for the Spring Framework.

Then in Kotlin one could write e.g. modifyResponseBody<String, String> { … } instead of modifyResponseBody(String::class.java, String::class.java) { … }.

Contributor guide

Tech stack
javakotlin
Domain
backenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Kotlin reified typesSpring Cloud Gateway API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the existing GatewayFilterSpec.java class at spring cloud gateway core/src/main/java/org/springframework/cloud/gateway/route/builder/GatewayFilterSpec.java to identify the methods modifyRequestBody and modifyResponseBody. Study the Kotlin extension functions implemented by @sdeleuze for Spring Framework (likely in spring framework repository) to understand the pattern. Then create a Kotlin file in the same module with extension functions that use reified type parameters. Ensure the extension functions are visible to Kotlin users of the library.