spring-cloud/spring-cloud-gateway

Add logging when max frame size is exceeded

Open

#1,048 opened on May 8, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (3,204 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,284 stars)
PR merge metrics
 (Avg merge 1d 21h) (18 merged PRs in 30d)

Description

When gateway is proxying websocket connections, if a message exceeds the max frame size, the websocket connection is dropped.

(This is related to #163)

However, there's no logging that indicates this has happened, even with TRACE level logging enabled in gateway.

It'd be very helpful if there was a warning message logged within the gateway that indicates this has happened. (Specifically, that the message exceeded the maxFrameSize, so the messages was dropped, and the websocket connection was terminated).

Contributor guide

Research direction
Find the location in the code where max frame size is checked and add a warning log statement.
Tech stack
java
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80