spring-attic/spring-cloud-security

OAuth2 intercepter for feign does not re-issue invalid token

Open

#220 opened on Sep 2, 2019

View on GitHub
 (3 comments) (8 reactions) (0 assignees)Java (525 stars) (250 forks)batch import
enhancementhelp wanted

Description

Hi,

If we check OAuth2RestTemplate it has an option retryBadAccessTokens which will try one more time to obtain new access token if previous token is invalid. This is useful if, for some reasons, you decide to revoke access token.

In OAuth2FeignRequestInterceptor access token is preserved in client context until it expires. There is no way to make feign to reissue new token until it expire.

The difficulty here that in feign interceptor is not responsible for retry. So what will be correct way to handle this issue? One of the option is to implement a feign retryer which will clean up client context.

If it is correct, do you want me to try to contribute this change?

Contributor guide

Tech stack
javaspring
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Spring OAuth2 experienceFeign client usageJava knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests a retry mechanism for invalid OAuth2 tokens in Feign interceptors. The author suggests implementing a Feign Retryer to clean up the client context on token invalidation. To contribute, review the current OAuth2FeignRequestInterceptor and understand how tokens are stored. Consider adding a retryer that catches exceptions and refreshes the token. Since the repository is archived, check for any successor projects or note that the issue may need to be addressed in a different library.