spotify/docker-client

Support host config cpus

Open

#959 opened on Jan 6, 2018

View on GitHub
 (10 comments) (2 reactions) (0 assignees)Java (551 forks)batch import
enhancementhelp wantedpinned

Repository metrics

Stars
 (1,430 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

Support host config --cpus=<value>

I know we have workaround, but it will be good to have --cpus.

set --cpus="1.5", the container will be guaranteed to be able to access at most one and a half of the CPUs. This is the equivalent of setting --cpu-period="100000" and --cpu-quota="150000". Available in Docker 1.13 and higher.

Contributor guide

Research direction
Find how existing host config options are implemented (e.g., cpuPeriod, cpuQuota) and add the ' cpus' parameter following the same pattern. Look for where HostConfig is built and ensure the new parameter is serialized correctly.
Tech stack
java
Domain
api
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65