spotify/docker-client

Support host config cpus

Open

#959 opened on Jan 6, 2018

View on GitHub
 (10 comments) (2 reactions) (0 assignees)Java (1,430 stars) (551 forks)batch import
enhancementhelp wantedpinned

Description

Description

Support host config --cpus=<value>

I know we have workaround, but it will be good to have --cpus.

set --cpus="1.5", the container will be guaranteed to be able to access at most one and a half of the CPUs. This is the equivalent of setting --cpu-period="100000" and --cpu-quota="150000". Available in Docker 1.13 and higher.

Contributor guide

Tech stack
java
Domain
apidevops
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaDocker APIUnderstanding of host config
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Review the HostConfig class in the source code (likely src/main/java/com/spotify/docker/client/messages/HostConfig.java). Check the Docker API documentation for the cpus option and its mapping to cpu period and cpu quota. The issue comments (10 total) may contain hints about implementation. Ensure to add a method to set cpus in the builder pattern used by HostConfig.