spotify/docker-client

listTasks should allow list of values in each filter

Open

#1092 opened on Oct 4, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (1,430 stars) (551 forks)batch import
bughelp wantedpinned

Description

Description

bug report

How to reproduce

The implementation of listTasks(Task.Criteria) here https://github.com/spotify/docker-client/blob/e1c7d47f778ec9c7e80279ecae812bf2098d4b34/src/main/java/com/spotify/docker/client/DefaultDockerClient.java#L2057 only allows one value for each filter. API docs state the value of each filter can be a list.

What do you expect

Allow a list of strings for each filter.

Software:

  • docker version: API 1.24+
  • Spotify's docker-client version: all

Contributor guide

Tech stack
javadocker
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaDocker APIList data structures
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Start by examining the `listTasks(Task.Criteria)` method in `DefaultDockerClient.java` (line 2057). Understand how filters are currently restricted to a single value per key. Modify the method and the `Task.Criteria` class to accept a list of values for each filter, ensuring compliance with Docker API v1.24+. Update the REST call to pass the list correctly. Test the change with multiple filter values.