spotify/docker-client

Add ForceUpdate to TaskSpec

Open

#1065 opened on Aug 31, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (1,430 stars) (551 forks)batch import
enhancementhelp wantedpinned

Description

The ForceUpdate parameter is missing from TaskSpec. It'd be useful to rebalance a service.

From the doc : ForceUpdate is a counter that triggers an update even if no relevant parameters have been changed

This should be equivalent to the command line : docker service update --force service_name

Contributor guide

Tech stack
java
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java programmingDocker fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Locate the TaskSpec class in the source code (e.g., com.spotify.docker.client.messages.swarm.TaskSpec). Add a private Long field 'forceUpdate' with corresponding getter and setter. Update the builder and/or constructor to include this field. Ensure the field is serialized correctly as 'ForceUpdate' in JSON. Check existing tests for TaskSpec and add a test that constructs a TaskSpec with a ForceUpdate value and verifies its presence in serialized output.