spockframework/spock

Mocking: Variables of Closure type aren't evaluated as code args

Open

#591 opened on May 31, 2016

View on GitHub
 (4 comments) (1 reaction) (0 assignees)Java (3,457 stars) (466 forks)batch import
component:docshelp wanted

Description

    def beatIt = {
      def result = (it >= now)
      Thread.sleep(1)
      now = System.currentTimeMillis()
      return result
    }

    when:
    task.execute(context)

    then:
    1 * loggingService.startJob(job, _, beatIt) >> jobExec    // doesn't work
    1 * loggingService.startJob(job, _, { beatIt(it) }) >> jobExec // works

Example is from one of my tests, where I discovered it.

From what I can tell, it is related to how you decide what is a code argument in the InteractionRewriter.addArg method. Maybe try also inspecting any VariableExpressions for closure type?

Contributor guide

Tech stack
groovyjava
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Groovy basicsSpock testing frameworkClosures
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the InteractionRewriter.addArg method to understand how code arguments are currently evaluated. Investigate how to detect VariableExpressions that represent closures, similar to how the existing code handles other code arguments. Consider adding logic to treat closure type variables as code arguments. The fix may involve modifying the addArg method to check the type of the expression.