The java-spiffe modules contain split packages which break the Java Modules (JPMS)
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- java
- Domain
- build-system
Research direction
Inspect the grpc.netty.macos.aarch64 and java.spiffe.core modules, focusing on the shared io.spiffe.workloadapi.internal package and the proposed module-info.java. Reproduce the JPMS compilation error for a dependent module, then verify that the chosen package or module structure no longer creates split packages and compiles successfully.
Written by the indexing model from the issue text.
Description
The Java Platform Module System (JPMS) introduced in Java 9 does not allow for split-packages. That is the same package in multiple JARs.
As a matter of fact java-spiffe has some split packages though, this breaks libraries that want to write modules depending on java-spiffe.
At least one of the offending packages leads to a compilation error: the unnamed module reads package io.spiffe.workloadapi.internal from both grpc.netty.macos.aarch64 and java.spiffe.core
Ideally the split package is removed by e.g. moving io.spiffe.workloadapi.internal in grpc.netty.macos.aarch64 to io.spiffe.workloadapi.grpc.netty.macosa.arch64.internal or similar.
Even better would be to define a proper java module for java-spiffe e.g. write a module-info.java file. This would also prevent future introduction of split packages.
- Dominant language
- Java
- Stars
- 46
- Forks
- 28
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from spiffe/java-spiffe
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
spiffe/java-spiffe#466 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
spiffe/java-spiffe#463 · 1 comment · 1 reaction ·
-
spiffe/java-spiffe#106 · 2 reactions · 1 assignee ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
spiffe/java-spiffe#80 · 6 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
spiffe/java-spiffe#79 · 2 comments ·
All issues in spiffe/java-spiffe
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
infinispan/infinispan#18150 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
opensearch-project/k-NN#3597 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100