separate spicetify menu items from spotify ones

Open
#2,900 0 comments 17 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
desktop, frontend

Research direction

Start by locating how Spotify menu items and context menus are registered, then compare that with the existing topbar button registration approach mentioned in the issue. The issue suggests either identifying the item containing an SVG with aria-label "External link" and adding the vvMORUKtQKpQcpQ992bR class, or separating registered menu items with a bottom border. Done means Spicetify and Spotify menu items are visually distinct without breaking normal context menus.

Written by the indexing model from the issue text.

Description

🔴 custom app
📝 Provide a description of the new feature

for example:

  • check through list of all li items
  • pick out the one containing an svg with aria-label External link
  • append vvMORUKtQKpQcpQ992bR classname to its button

alternatively:
or via some other method idk how menu items and context menus now work, potentially create a store of all menu items registered like we do with topbar buttons and if its the first one to be registered add a border to the bottom of it instead? that approach could also work for normal context menus that way!

➕ Additional Information

image

Dominant language
JavaScript
Stars
24.6k
Forks
941
Avg merge
11h 31m
Merged PRs (30d)
24

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from spicetify/cli

All issues in spicetify/cli

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.