spencermountain/timezone-soft

Dublin Timezone code displays as BST during summertime

Open

#19 opened on Aug 22, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (7 forks)github user discovery
good first issue

Repository metrics

Stars
 (27 stars)
PR merge metrics
 (PR metrics pending)

Description

I'm using react-timezone-select, and it displays the timezone code for Dublin as BST during summertime.

image

However, the JavaScript getLocaleString function displays it as GMT+1:

image

(London displays as BST and Lisbon displays as WEST).

The thing is, Irish people do not like being referred to as British, so British Summer Time is not liked as a term here. Informally we tend to use IST for Irish Summer Time (which unfortunately clashes with Indian Standard Time). Officially Ireland uses GMT in wintertime, and IST (Irish Standard Time) in summer. This clashes with Indian Standard Time, but apparently timezone codes are not unique. Personally I think we should adopt WEST like Lisbon.

I believe the source of the problem is in the data/Europe.js file, which under "Europe/Dublin" has "meta": "British". See above about Irish people not liking being called British.

Contributor guide

Research direction
Inspect the Europe.js file and update the meta field for Europe/Dublin to an appropriate value (e.g., 'Irish' or remove it) to avoid displaying BST.
Tech stack
javascript
Domain
data
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85