spencermountain/spacetime

i18n `.since()`

Open

#110 opened on Mar 18, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (3,809 stars) (189 forks)batch import
enhancementfixed-on-devhelp wantedready

Description

Seems like the since method's output is hardcoded to English? https://github.com/spencermountain/spacetime/blob/8b93859d23cfd828dca7de50cc8ec72105393cf4/src/methods/since.js#L132

Any thoughts on allowing i18n as per the custom languages example?

Contributor guide

Tech stack
javascriptnodejs
Domain
internationalizationlocalization
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with spacetime's custom language systemJavaScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the file src/methods/since.js around line 132 to understand how the 'since' method currently outputs hardcoded English strings. Review the existing custom language implementation (e.g., in src/languages) to see how other methods localized their output. Propose changes to 'since' to accept a language parameter or use the library's default language, and provide an example of how to add translations for the relative time phrases.