spencermountain/spacetime

i18n `.since()`

Open

#110 opened on Mar 18, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (189 forks)batch import
enhancementfixed-on-devhelp wantedready

Repository metrics

Stars
 (3,809 stars)
PR merge metrics
 (Avg merge 16h 33m) (4 merged PRs in 30d)

Description

Seems like the since method's output is hardcoded to English? https://github.com/spencermountain/spacetime/blob/8b93859d23cfd828dca7de50cc8ec72105393cf4/src/methods/since.js#L132

Any thoughts on allowing i18n as per the custom languages example?

Contributor guide

Research direction
Investigate the `since` method in the source code, understand the current hardcoded strings, and implement a way to pass locale or use the library's i18n mechanism.
Tech stack
javascript
Domain
internationalization
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70